Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify comment #60

Open
Atulin opened this issue Sep 8, 2021 · 4 comments
Open

Simplify comment #60

Atulin opened this issue Sep 8, 2021 · 4 comments
Labels
backlog This issue goes to the very end of the queue data layer Issues related to the data layer – database and entities that describe it enhancement New feature or request help wanted Extra attention is needed priority:medium Medium priority issues that should be fixed but aren't breaking

Comments

@Atulin
Copy link
Collaborator

Atulin commented Sep 8, 2021

Currently, we need a whole-ass comment redirector service that can figure out where a given comment goes, what's its ordinal number, and a whole lot of other stuff. It would be great if we could somehow simplify it all.
@Atulin Atulin added enhancement New feature or request help wanted Extra attention is needed data layer Issues related to the data layer – database and entities that describe it priority:medium Medium priority issues that should be fixed but aren't breaking backlog This issue goes to the very end of the queue labels Sep 8, 2021
@Atulin
Copy link
Collaborator Author

Atulin commented Sep 8, 2021

Perhaps hashids would be of help? There's support for both .NET and Postgres, and it would potentially eliminate the need for sequential comment numbers per thread.

@Atulin
Copy link
Collaborator Author

Atulin commented Sep 8, 2021

Two links that can help figure out the page on which a comment is:

@Atulin
Copy link
Collaborator Author

Atulin commented Sep 9, 2021

Bit of a performance improvement for the comment redirector, query times wend down from 2ms to 1ms for 38 comments, probably more should the amount of comments per thread be higher: 661b5be

@Atulin
Copy link
Collaborator Author

Atulin commented Sep 10, 2024

Does each comment returned from the API need info about whether the current user owns it? Can't we discern it on the frontend?

@Atulin Atulin mentioned this issue Sep 10, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
backlog This issue goes to the very end of the queue data layer Issues related to the data layer – database and entities that describe it enhancement New feature or request help wanted Extra attention is needed priority:medium Medium priority issues that should be fixed but aren't breaking
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Atulin