General Comment Enhancements #104
Comments
Atulin
added a commit
that referenced
this issue
Sep 10, 2024
- Now a single handler for all comments instead of four separate ones - Now discernible by an enum, not by strings - Removed edit count and last edited date from comment entity. That data isn't necessary for display and can be trivially procured from the list of revisions - Disallowed Markdown headings in comments - JS code now uses generated paths properly - Removed notifications from comments, see #104
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Notifications
Subscribing to arbitrary threads is a bit too much, methinks. It's just the post/chapter/profile owner who should be notified of new comments on their stuff. Temporarily removed all notifications from new comments (52eaa9c) until a better solution for that can be found.
Complexity
Comments are hella complex, perhaps something can be simplified? See #60
Vue
It's... a mess. Non-compiled Vue 2 components that take server-side rendered page as a template, causing a ton of false warnings in the IDE and a generally miserable experience. The same is true for other places where Vue is used this way, but it sticks out here the most, since comments are so complex.
Perhaps we could consider moving to Lit, and compiling the whole thing all nice and proper-like? Perhaps the comment box can just be a separate, embedded Vue app?
The text was updated successfully, but these errors were encountered: