Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sdk): incorrect args for helper class user. #2

Merged
merged 1 commit into from
May 17, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
79 changes: 79 additions & 0 deletions packages/sdk/src/roles/user.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ import path from "path";

import { describe, expect, it } from "vitest";
import { prepare, isPrepared } from "@/crypto/babyzk/deps";
import { poseidonBigInts } from "@/crypto/hash";
import * as credType from "@/credential/credType";
import * as credential from "@/credential/credential";
import * as claimType from "@/credential/claimType";
Expand Down Expand Up @@ -141,4 +142,82 @@ describe("user and issuer class", () => {
expect(proofOk).toBe(true);
}
});

it("generated proof has correct public signals", async () => {
const artifactsDir = path.resolve(__dirname, "../testutils/artifacts");
const u = new User();
const evmIdSlice = u.createNewIdentitySlice("evm");
const userIdc = User.computeIdentityCommitment(evmIdSlice);
const tp = unwrap(credType.createTypeFromSpec(unit));
const contextId = 11n;
const userId = 22n;
const expiredAtLowerBound = "1";
const externalNullifier = "2";
const equalCheckId = "3";
const pseudonym = "4";
const cred = unwrap(
credential.Credential.create(
{
type: tp,
contextID: contextId,
userID: userId,
},
{}
)
);
const pk = decodeFromHex(skStr);
const myIssuer = new BabyzkIssuer(pk, 1n, 1n);
myIssuer.sign(cred, {
sigID: BigInt(100),
expiredAt: BigInt(1715899510),
identityCommitment: userIdc,
});
expect(cred.isSigned()).toBe(true);

// proof generation
const proofGenGadgets = await User.loadProofGenGadgetsFromFile(
`${artifactsDir}/unit/circom.wasm`,
`${artifactsDir}/unit/circuit_final.zkey`
);
// Finally, let's generate the proof.
const proof = await u.genBabyzkProof(
userIdc,
cred,
{
expiratedAtLowerBound: BigInt(expiredAtLowerBound),
externalNullifier: BigInt(externalNullifier),
equalCheckId: BigInt(equalCheckId),
pseudonym: BigInt(pseudonym),
},
proofGenGadgets,
[]
);
// proof matches the verification key
const vkey = JSON.parse(fs.readFileSync(`${artifactsDir}/unit/circuit.vkey.json`, "utf-8"));
const proofOk = await babyzk.verifyProofRaw(vkey, proof);
expect(proofOk).toBe(true);

// calculate out_id_equals_to (prop<248, c, 1>). Since the least significant bit designates equality,
// we need to shift the value by 1 bit to the left.
const idEqualsTo = BigInt(equalCheckId) << 1n;

expect(proof.publicSignals).toStrictEqual([
// Type
tp.typeID.toString(),
// Context
contextId.toString(),
// Nullifier
poseidonBigInts([evmIdSlice.internalNullifier, BigInt(externalNullifier)]).toString(),
// ExternalNullifier
externalNullifier,
// RevealIdentity
pseudonym,
// ExpirationLb
expiredAtLowerBound,
// KeyId
"1743582416365651167392966598529843347617363862106697818328310770809664607117",
// IdEqualsTo
idEqualsTo.toString(),
]);
});
});
2 changes: 1 addition & 1 deletion packages/sdk/src/roles/user.ts
Original file line number Diff line number Diff line change
Expand Up @@ -197,8 +197,8 @@ export class User {
const input = babyzk.genCircuitInput(
cred,
userSecrets,
proofOptions.externalNullifier,
proofOptions.pseudonym,
proofOptions.externalNullifier,
new statement.StatementList(proofOptions.expiratedAtLowerBound, proofOptions.equalCheckId, statements)
);
return await babyzk.genProof(proofGenGadgets.wasm, proofGenGadgets.zkey, input);
Expand Down
Loading