Adds a new C++ test, with associated known_bugs entry for current failure #265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
langston-barrett
approved these changes
Jan 2, 2024
| @@ -0,0 +1,10 @@ | |||
| ##> rootMatchName: p2.cpp | |||
There was a problem hiding this comment.
Is there a corresponding issue number for this bug? Should we make one?
peterohanley
reviewed
Jan 6, 2024
| Using this module's llvm-disasm to convert the clang++ generated bitcode into assembly (.ll), the resulting assembly is invalid for llvm-as: | ||
|
|
||
| error: expected type | ||
| define linkonce_ddr default i32 @_ZN4uorb14uorb_advertiseEPK21orb_metadata(%class.uorb* %32 |
There was a problem hiding this comment.
This error is just a typo, it should be linkonce_odr. The data member is named correctly, the error is here: https://github.com/elliottt/llvm-pretty/blob/8124fc0265b6ca5fde5812c789f40b2ea54af678/src/Text/LLVM/PP.hs#L463
With this fixed, there is an instance of #222 which is probably the same cause.
There was a problem hiding this comment.
I reduced p2.cpp (for #222) to
struct h {
bool a;
};
void g(struct h *s) {
}
void f() {
struct h s;
}
I do not have a fix yet, but the bitcode is now small enough to walk through manually.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[Requires #264 to be actually used.]