Fix tab completion for :t and :check
#1781
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the user types `:<CMD> ...` and `<CMD>` matches a defined command exactly, then commit to that command's tab completion. (Previously, the tab completion logic would consider all possible commands for which `<CMD>` is a prefix, but this is silly when you have an exact match with an existing command.) Fixes #1780.
RyanGlScott
temporarily deployed
to
github-pages
GitHub Actions
Inactive
sauclovian-g
reviewed
Dec 6, 2024
RyanGlScott
temporarily deployed
to
github-pages
GitHub Actions
Inactive
RyanGlScott
force-pushed
the
T1780-fix-tab-completion-for-t-and-check
branch
from
7c21461 to
9275d1b
Compare
RyanGlScott
temporarily deployed
to
github-pages
GitHub Actions
Inactive
RyanGlScott
force-pushed
the
T1780-fix-tab-completion-for-t-and-check
branch
from
9275d1b to
e762379
Compare
RyanGlScott
temporarily deployed
to
github-pages
GitHub Actions
Inactive
RyanGlScott
force-pushed
the
T1780-fix-tab-completion-for-t-and-check
branch
from
e762379 to
18cd8eb
Compare
RyanGlScott
temporarily deployed
to
github-pages
GitHub Actions
Inactive
RyanGlScott
force-pushed
the
T1780-fix-tab-completion-for-t-and-check
branch
from
18cd8eb to
5312228
Compare
RyanGlScott
temporarily deployed
to
github-pages
GitHub Actions
Inactive
This adds a dedicated `cryptol-api-tests` test suite which exercises properties of the Cryptol API that are inconvenient to check with the Cryptol executable itself (e.g., properties of the REPL's tab completion). I have also rejigged the CI so that `cryptol-api-tests` is run on each CI run.
RyanGlScott
force-pushed
the
T1780-fix-tab-completion-for-t-and-check
branch
from
5312228 to
0e8ddd1
Compare
RyanGlScott
temporarily deployed
to
github-pages
GitHub Actions
Inactive
This ensures, among other things, that `:check` completes to `:check` (not `:check `, as was the case before). I have added even more regression tests to check for this.
RyanGlScott
temporarily deployed
to
github-pages
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the user types
:<CMD> ...and<CMD>matches a defined command exactly, then commit to that command's tab completion. (Previously, the tab completion logic would consider all possible commands for which<CMD>is a prefix, but this is silly when you have an exact match with an existing command.)Fixes #1780.