crucible-syntax: Allow exotic characters in fresh atom names
#1266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sauclovian-g
approved these changes
Nov 26, 2024
Previously, we used `userSymbol` to create fresh atom names, but `userSymbol` will fail if given any characters outside of the very narrow range of characters allowed in What4 solver names. Instead, we now use `safeSymbol`, which will Z-encode any unallowable characters into something that is allowed in a What4 solver name. This ensures (among other things) that we can write things like `(let i-3 (fresh Bool))`, as hyphens are not allowed in What4 solver names without Z-encoding them. Fixes #1024.
RyanGlScott
force-pushed
the
T1024-crucible-syntax-exotic-fresh-var-names
branch
from
303cc61 to
8be1cd0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we used
userSymbolto create fresh atom names, butuserSymbolwill fail if given any characters outside of the very narrow range of characters allowed in What4 solver names. Instead, we now usesafeSymbol, which will Z-encode any unallowable characters into something that is allowed in a What4 solver name. This ensures (among other things) that we can write things like(let i-3 (fresh Bool)), as hyphens are not allowed in What4 solver names without Z-encoding them.Fixes #1024.