Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

llvm: Print out the failed predicate in a panic #1254

Merged
merged 1 commit into from
Sep 11, 2024
Merged

llvm: Print out the failed predicate in a panic #1254

merged 1 commit into from
Sep 11, 2024

Conversation

langston-barrett
Copy link
Contributor

No description provided.

@langston-barrett langston-barrett self-assigned this Sep 11, 2024
RyanGlScott
RyanGlScott approved these changes Sep 11, 2024
View reviewed changes
Copy link
Contributor

@RyanGlScott RyanGlScott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable. Perhaps it's worth printing out the predicate in the NoErr case just above it as well?

@langston-barrett langston-barrett merged commit e8e0c53 into master Sep 11, 2024
32 checks passed
@langston-barrett langston-barrett deleted the lb/mem-model-panic branch September 11, 2024 22:37
@langston-barrett
Copy link
Contributor Author

Perhaps it's worth printing out the predicate in the NoErr case just above it as well?

Perhaps? It's not really the predicate that's the problem in that case, but rather, the shape of the data (which is already printed).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RyanGlScott RyanGlScott RyanGlScott approved these changes

Assignees

@langston-barrett langston-barrett

Labels
llvm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@langston-barrett @RyanGlScott