Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revise Haddocks for Crucible backends #1249

Merged
merged 1 commit into from
Sep 11, 2024

Conversation

langston-barrett
Copy link
Contributor

The fact that these backends use an AssumptionStack is an implementation detail that is not exposed via their interface, instead clients interact with getProofObligations is an implementation detail that is not exposed via their interface, instead clients interact with getProofObligations.

Also, point to a module that helps with dispatching such obligations.

Copy link
Contributor

@RyanGlScott RyanGlScott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I think the commit message accidentally copy-pasted too much, however, as the phrase "implementation detail that is not exposed via their interface" appears twice (making the sentence appear to a run-on sentence).

The fact that these backends use an `AssumptionStack` is an
implementation detail that is not exposed via their interface, instead
clients interact with `getProofObligations`.

Also, point to a module that helps with dispatching such obligations.
@langston-barrett
Copy link
Contributor Author

Good catch, thanks @RyanGlScott! Fixed the commit message.

@langston-barrett langston-barrett merged commit 86f1f2e into GaloisInc:master Sep 11, 2024
32 checks passed
@langston-barrett langston-barrett deleted the lb/backend-docs branch September 11, 2024 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants