-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
crucible-mir
: Properly parse ArrayToPointer
casts
#1225
Conversation
Currently, `crucible-mir`'s implementation of `CastKind` lags behind the `rustc` API's `CastKind` enum. Let's leave a link to the relevant issue (#1223) as breadcrumbs.
After my changes, the
Fair enough, since I changed the relevant code which casts from an array reference (or, in this case, an array pointer) to a pointer to look for As such, I think I will do the simplest possible thing and map |
Although `crucible-mir` had support for translating these sorts of casts (`ArrayToPointer` casts), it did not parse them properly. This patch ensures that `ArrayToPointer` casts are parsed as `Misc`, which allows them to be handled by the code in `Mir.Trans`. Fixes #1224.
b07ad45
to
edddf4b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like a reasonable option for a quick fix.
This bumps the `crucible` submodule to bring in the changes from GaloisInc/crucible#1225, which fixes GaloisInc/crucible#1224 on the SAW side. This also requires bumping the `cryptol`, `macaw`, and `what4` submodules in order to construct a consistent build plan with the latest `crucible`.
This bumps the `crucible` submodule to bring in the changes from GaloisInc/crucible#1225, which fixes GaloisInc/crucible#1224 on the SAW side. This also requires bumping the `cryptol`, `macaw`, and `what4` submodules in order to construct a consistent build plan with the latest `crucible`.
Although
crucible-mir
had support for translating these sorts of casts (ArrayToPointer
casts), it did not parse them properly. This patch ensures thatArrayToPointer
casts are parsed asMisc
, which allows them to be handled by the code inMir.Trans
.Fixes #1224.