Make cabal sdist work for crucible-cli{,-llvm}
#1210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Neither package's `.cabal` file contains a `README.md` file, so remove mention of this file name from the `extra-doc-files`. * `crucible-cli.cabal` uses double-star syntax (`test-data/**/*.cbl`) in its `extra-source-files`, which requires a `cabal-version` or `2.4` or greater. Make sure that `crucible-cli.cabal` properly declares this version dependency. Fixes #1209.
langston-barrett
approved these changes
Jun 7, 2024
The most direct way would be to run |
It is possible to misconfigure a package's `.cabal` file in a way that is not easily detectable unless you try to bundle the package into a source distribution (e.g., through the `cabal sdist` or `cabal install` commands). These sorts of misconfigurations have snuck into the `crucible`-related packages in the past (see #1209 for one such example). To prevent these sorts of issues from happening in the future, we now run `cabal sdist` on each package in the CI as a sanity check.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Neither package's
.cabalfile contains aREADME.mdfile, so remove mention of this file name from theextra-doc-files.crucible-cli.cabaluses double-star syntax (test-data/**/*.cbl) in itsextra-source-files, which requires acabal-versionor2.4or greater. Make sure thatcrucible-cli.cabalproperly declares this version dependency.Fixes #1209.