RFC: Remove handling of attributes #105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The API around attributes changed in LLVM 14. Rather than blindly upgrade the FactGenerator to continue to type-check, I realized that 1. Attribute handling was probably already incomplete - I'm sure LLVM 10-13 added new attributes that I hadn't yet updated the schema and FactGenerator to account for. 2. I wasn't really sure how attributes impacted the analysis. I decided to try to delete everything related to attributes instead. The idea is that if we don't use them, they're just slowing everything down and adding a maintenance burden, even while we *know* that the current support isn't comprehensive (and thus not useful to e.g., other clients of the FactGenerator). This appears to pass all of the tests, including the golden tests and `EXTRA_TESTS`. It's certainly possible that the analysis changes would impact the output on programs that do use the `byval` attribute and that we don't have enough coverage of these in the test suite. However, it seems comparably likely that some aspect of the LLVM language changed in a way that made this code not work the way it was intended to when it was originally written.
|
@thinkmoore and I discussed offline and we aligned on this approach. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The API around attributes changed in LLVM 14. Rather than blindly upgrade the FactGenerator to continue to type-check, I realized that
I decided to try to delete everything related to attributes instead. The idea is that if we don't use them, they're just slowing everything down and adding a maintenance burden, even while we know that the current support isn't comprehensive (and thus not useful to e.g., other clients of the FactGenerator).
This appears to pass all of the tests, including the golden tests and
EXTRA_TESTS. It's certainly possible that the analysis changes would impact the output on programs that do use thebyvalattribute and that we don't have enough coverage of these in the test suite. However, it seems comparably likely that some aspect of the LLVM language changed in a way that made this code not work the way it was intended to when it was originally written. See #104.See also #26.