telemetry: library for creating, storing, and reading events #137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avoid handling the case where a user provides a non-filename-compatible source string, and hope the resulting hit to disk space isn't too bad
Instead, embed it in the file structure. Somewhat of a reversion of 0bcaf91, handling the error that sought to avoid by hashing the source string to obtain a known-filename-compatible string.
The former should be the source of truth, while the latter only happens to correspond to it.
No functional change intended.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements a small library for storing and loading telemetric events, towards #125. This library aims to be generic over the type of logic associated with application-specific data, and only concerns itself with basic event metadata and storage mechanism(s).
To realize #125, my next step will be to have the CN language server depend on this library, define a custom telemetry event type that's expansive enough to cover the requirements described in that issue, and begin logging those events as it receives and processes user interactions.