Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement long versions of ItemStack and FluidTanks #6

Merged
merged 22 commits into from
Apr 21, 2024

Conversation

BlueWeabo
Copy link
Member

@BlueWeabo BlueWeabo commented Mar 14, 2024

TODO:

  • Implement long versions of FluidTanks and ItemStacks
  • Make FluidSlot use of IFluidTanksHandler
  • Make sure correct implementation of IItemStackLong was done
  • Make sure correct reimplementation for ItemSlot was done to take care with the conversion to IItemStackLong.

@BlueWeabo BlueWeabo changed the title Prepare for migration Implement long versions of ItemStack and FluidTanks Mar 19, 2024
Copy link
Member

@miozune miozune left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for late review, and thanks for your hard work.

@BlueWeabo BlueWeabo marked this pull request as ready for review April 21, 2024 07:35
Copy link
Member

@miozune miozune left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nitpicks mostly from Intellij suggestions (this review is not sponsored by Jetbrains 😉)

Copy link
Member

@miozune miozune left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@miozune miozune merged commit eaa2eca into master Apr 21, 2024
1 check passed
@miozune miozune deleted the prepareForMigration branch April 21, 2024 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants