Better Mouse Position Unprojection #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lyfts
approved these changes
May 6, 2024
|
Btw was the old code tested with newest Angelica? If it's still broken, that's still an Angelica bug - this would just be a workaround/different implementation, but we'd definitely want to figure out what's broken in Angelica too. |
|
I tested it with Alpha 43 yesterday and the issue was still there. I'm not sure how useful it is but I wrote some stuff here GTNewHorizons/Angelica#383 when I tested it with Alpha 42 a few days ago. |
Dream-Master
pushed a commit
that referenced
this pull request
May 20, 2024
* add support for non-gt multis * bs+deps * move stuff into relevant package * deobfParams * spotlessApply (#15) * remove double dep * small cleanup * this has no uses and not touched for 2 years * not needed * address reviews * unproject mouse position without OpenGL --------- Co-authored-by: Lyfts <[email protected]> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> (cherry picked from commit 064f7bf)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes GTNewHorizons/Angelica#383 by not using OpenGL to unproject position.
I also removed some unused clutter.
Codes are from my newer project:
https://github.com/Quarri6343/OpenARPG/blob/b2d6ef09bf639cf77a2ac24082d0bccb3a015c0b/src/main/java/quarri6343/openarpg/ProjectionUtil.java#L69-L99