-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce USWDS theming and upgrade to USWDS 3.8. #1425
Conversation
@@ -251,21 +251,6 @@ tbody tr:hover td { | |||
text-decoration: none; | |||
} | |||
|
|||
.usa-table { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These overrides were replaced by setting $theme-table-border-color
in uswds/_uswds-theme.scss
.
@@ -10,7 +10,7 @@ | |||
* files in this directory. Styles in this file should be added after the last require_* statement. | |||
* It is generally better to create a new file per style scope. | |||
* | |||
*= require uswds |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Renamed because I couldn't figure out a way to get the USWDS compiler to generate the file with its original name.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wish this was not minified but that's how the USWDS compiler operates. There is a feature request in uswds-compile asking to make minification optional. Admittedly, that is a very old feature request and the project hasn't had a release for a long time but I could ask about it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sanason - thank you!
this is looking good and accomplishes:
- a better uswds build process
- minified versions of the assets are in place
- updated assets (icons)
- kept style customizations
- removed old, non-minified assets
This PR does 2 things:
Number 2 is just a proposal, from a brand new member of the team who has no context on why things are done the way they are done so, reviewers, feel free to criticize. That said, I think the new procedure offers these benefits:
package.json
).gulp updateUswds
).Testing
Did the upgrade to 3.8 break anything in the Touchpoints app? Did the upgrade to 3.8 break anything in the display of questionnaire forms?
No changes that I can see. The only breaking change listed (in 3.8) concerns the class
usa-layout-docs__sidenav
which, as far as I can tell, we aren't really using.Do our tables look the same after using the
theme-table-border-color
setting to customize their appearance?Yes, borders look the same.