add corresponding dataset page to download file and outbound click tables #374
Conversation
| {%- assign pageURL = 5 -%} | ||
| {%- if block.data[0][forloop.index0] == "pageTitle" -%} | ||
| <td align="right"> | ||
| <a href="{{row[pageURL]}}" target="_blank">{{column | toLocaleString | replace: " - Catalog", ""}}</a> |
There was a problem hiding this comment.
what's this line doing exactly?
There was a problem hiding this comment.
if the current column in row corresponds to the pageTitle column then add the original catalog page ( row[pageURL] ) the file was clicked on as a hyperlink with some string munging. i created the pageURL var to stand out and describe what the index represents rather than just doing row[5]. I can try to change this to make it more readable. frankly i'm not super familiar with templating languages.
There was a problem hiding this comment.
i derive the dataset title from the html title using the pageTitle GA dimension which includes " - Catalog" at the end
There was a problem hiding this comment.
i derive the dataset title from the html title using the pageTitle GA dimension which includes " - Catalog" at the end
the string replace was the part that got me. i guess we do it for every dataset so i expect it's fine.
Changes proposed in this pull request:
related to #4992
security considerations
[Note the any security considerations here, or make note of why there are none]