make gim compatible with kernel >= 5.0

[flumm]

kernel 5.0 removed some deprecated timespec/timeval functions
so conditionally convert everything to timespec64

Signed-off-by: Dominik Csapak [email protected]

[ljymonk]

Hi flumm You’d better make your change compatible with pre-5.0 kernel: [cid:[email protected]] Look your change would break old kernel , e.g. 4.13 Maybe you can use MACROS to differentiate whether use timespec or TIMESPECTYPE /Monk From: flumm <[email protected]> Sent: Tuesday, June 25, 2019 4:06 AM To: GPUOpen-LibrariesAndSDKs/MxGPU-Virtualization <[email protected]> Cc: Subscribed <[email protected]> Subject: [GPUOpen-LibrariesAndSDKs/MxGPU-Virtualization] make gim compatible with kernel >= 5.0 (#24) kernel 5.0 removed some deprecated timespec/timeval functions so conditionally convert everything to timespec64 Signed-off-by: Dominik Csapak [email protected]<mailto:[email protected]>

…

________________________________ You can view, comment on, or merge this pull request online at: #24 Commit Summary * make gim compatible with kernel >= 5.0 File Changes * M drv/gim_adapter.c<https://github.com/GPUOpen-LibrariesAndSDKs/MxGPU-Virtualization/pull/24/files#diff-0> (38) * M drv/gim_adapter.h<https://github.com/GPUOpen-LibrariesAndSDKs/MxGPU-Virtualization/pull/24/files#diff-1> (36) * M drv/gim_dma.c<https://github.com/GPUOpen-LibrariesAndSDKs/MxGPU-Virtualization/pull/24/files#diff-2> (8) * M drv/gim_irqmgr.c<https://github.com/GPUOpen-LibrariesAndSDKs/MxGPU-Virtualization/pull/24/files#diff-3> (8) * M drv/gim_monitor.c<https://github.com/GPUOpen-LibrariesAndSDKs/MxGPU-Virtualization/pull/24/files#diff-4> (2) * M drv/gim_monitor_ioctl.c<https://github.com/GPUOpen-LibrariesAndSDKs/MxGPU-Virtualization/pull/24/files#diff-5> (2) * M drv/gim_monitor_ioctl.h<https://github.com/GPUOpen-LibrariesAndSDKs/MxGPU-Virtualization/pull/24/files#diff-6> (2) Patch Links: * https://github.com/GPUOpen-LibrariesAndSDKs/MxGPU-Virtualization/pull/24.patch * https://github.com/GPUOpen-LibrariesAndSDKs/MxGPU-Virtualization/pull/24.diff — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub<#24?email_source=notifications&email_token=AG4GO4LSGZ7OV5LRK6CMPDDP4HGVDA5CNFSM4H3FR5X2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4G3PGZ7A>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AG4GO4IEY3IFW3V46RDFKDTP4HGVDANCNFSM4H3FR5XQ>.

[flumm]

Maybe you can use MACROS to differentiate whether use timespec or TIMESPECTYPE

but i am doing exactly this?

in gim_adapter.h i define TIMESPECTYPE as timespec for kernels < 5 and as timespec64 for kernels >= 5

i did this to avoid dozens of
#if LINUX_VERSION_CODE <... .. #else ... #endif

blocks.

also i can build and load it here on an debian stretch with kernel 4.9.0 without problems

[ljymonk]

oh, sorry,didn't look into othe files yet 获取 Outlook for Android<https://aka.ms/ghei36>

…

________________________________ From: flumm <[email protected]> Sent: Wednesday, June 26, 2019 3:35:01 AM To: GPUOpen-LibrariesAndSDKs/MxGPU-Virtualization Cc: Liu, Monk; Comment Subject: Re: [GPUOpen-LibrariesAndSDKs/MxGPU-Virtualization] make gim compatible with kernel >= 5.0 (#24) Maybe you can use MACROS to differentiate whether use timespec or TIMESPECTYPE but i am doing exactly this? in gim_adapter.h i define TIMESPECTYPE as timespec for kernels < 5 and as timespec64 for kernels >= 5 i did this to avoid dozens of #if LINUX_VERSION_CODE <... .. #else ... #endif blocks. also i can build and load it here on an debian stretch with kernel 4.9.0 without problems ― You are receiving this because you commented. Reply to this email directly, view it on GitHub<#24?email_source=notifications&email_token=AG4GO4M7JNKL4X67AORAW53P4ML2LA5CNFSM4H3FR5X2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODYST55Q#issuecomment-505757430>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AG4GO4OVW7Q7YYMC5E6HLSLP4ML2LANCNFSM4H3FR5XQ>.

[flumm]

Oh no problem

[tuxis-ie]

Pretty please @ljymonk ?

[srinivamd]

Does gim support 5.x kernel?

[flumm]

Does gim support 5.x kernel?

well i'm using it with this pull request since quite some time up to kernel 5.4 (cannot say for newer kernels), so i'd say it works, but since nobody from amd commented yet, i do not know if its 'supported'

[mac-linux-free]

Could you please make GIM compatible with newer Kernels? 5.9+

https://github.com/fabianishere/pve-edge-kernel

Thank you.