Remove stat #131
Closed
Remove stat #131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
an alternative is making these checks "optional" so they are applied if the stat result is available so you get some partial safety from this |
cmdcolin
force-pushed
the
remove_stat
branch
2 times, most recently
from
464e899 to
2ce6ccf
Compare
|
Revisited this PR to fetch files from external buckets we don't necessarily have control of e.g. this file https://ont-open-data.s3.amazonaws.com/colo829_2024.03/wf_somatic_variation/sup/COLO829_tumor.ht.cram which is from the ONT bucket. the bucket has CORS enabled, but not CORS for Content-Range header access. this makes it fail when trying to get the stat() for "file length" This PR removes the file length checks it passes all tests except 1 currently |
Misc Misc
Misc Misc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes checks for "file out of bounds" to cram-js
While the code is a bit "safer" perhaps with these checks, they require that "stat" works which requires specialized CORS headers to be set. Access to files for example https://ftp.1000genomes.ebi.ac.uk/vol1/ftp/data_collections/HGDP/data/Sindhi/HGDP00171/alignment/HGDP00171.alt_bwamem_GRCh38DH.20181023.Sindhi.cram work with this PR enabled, but not without this PR
Draft PR because tests may be non-passing, but tested in the genome browser