Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add automatic birthday balloons #1849

Merged
merged 1 commit into from
Jun 27, 2024

Conversation

tomudding
Copy link
Member

Description

For the past few years I have manually added the balloons to the website on the 28th of June, however, it is better to just have this implemented so I do not have to do this anymore.

For GEWIS' 40th birthday it was decided that 40 balloons was optimal for both small and large screens. This should not be changed without careful consideration as it may negatively affect the usability of the website.


Removal of entry in .gitignore came from GH-1790 to ensure that the SCSS files are tracked.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation improvement (no changes to code)
  • Other (please specify)

For the past few years I have manually added the balloons to the website on the
28th of June, however, it is better to just have this implemented so I do not
have to do this anymore.

For GEWIS' 40th birthday it was decided that 40 balloons was optimal for both
small and large screens. This should not be changed without careful
consideration as it may negatively affect the usability of the website.

---

Removal of entry in `.gitignore` came from GEWISGH-1790 to ensure that the SCSS files
are tracked.
@tomudding tomudding merged commit 25c576f into GEWIS:main Jun 27, 2024
4 checks passed
github-actions bot added a commit that referenced this pull request Jun 27, 2024
Tom Udding: Merge pull request #1849 from tomudding/feature/automatic-birthday-balloons

Add automatic birthday balloons

Co-authored-by: tomudding <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant