ct.c tuneups from NCBI as of May 2024 #561
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Explicitly build cmd->iodesc->name and update ...->namelen along the way rather than calling sprintf and strlen (which can be slow). Signed-off-by: Aaron M. Ucko <[email protected]>
Report (anticipated) truncation when given data for a variable-width type whose maximum width is less than the supplied data length. (The actual truncation will occur in libtds code that cannot readily complain about it.) To that end, copy error code 36's description from cs.c. Signed-off-by: Aaron M. Ucko <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains two tuneups to
ct.cfrom #555 thatgit-depsflagged as interdependent, though it looks like that may have been a false positive.