Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix type hints of Node methods #1492

Merged
merged 2 commits into from
Nov 13, 2023
Merged

Conversation

pinterior
Copy link
Contributor

@pinterior pinterior commented Nov 13, 2023

Closes #1466, Closes #1491

  • fix type hints of functions which call _parse_nodeid_qname
  • fix type hint of add_object

for nodeid and bname, valid combinations are only (int, str) and (NodeId | str, QualifiedName, str).
(it's possible to put two @overloads to reject (int, QualifiedName) case)

@oroulet oroulet merged commit a6fe064 into FreeOpcUa:master Nov 13, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect type hints on Node methods Incorrect typing on Node.add_object
2 participants