Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve an error message in visc_load_pdata() #253

Merged
merged 1 commit into from
Dec 10, 2024
Merged

Improve an error message in visc_load_pdata() #253

merged 1 commit into from
Dec 10, 2024

Conversation

slager
Copy link
Contributor

@slager slager commented Dec 10, 2024 •
edited
Loading

Description

Resolves #252 by improving an error message in visc_load_pdata() to include the data package name. Useful for debugging failures due to non-standard data object names, when the function looks for a data object in a data package that is not the data package the user may have been expecting.

Related Issues

#252

Checklist

  • This PR includes unit tests
  • This PR establishes a new function or updates parameters in an existing function
    • The roxygen skeleton for this function has been updated using devtools::document
  • I have updated NEWS.md to describe the proposed changes

@slager slager changed the base branch from main to develop December 10, 2024 16:31
@codecov Codecov
Copy link

codecov bot commented Dec 10, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.05%. Comparing base (daa8494) to head (1264b0b).
Report is 2 commits behind head on develop.

Additional details and impacted files 
@@             Coverage Diff             @@
##           develop     #253      +/-   ##
===========================================
+ Coverage    81.73%   82.05%   +0.31%     
===========================================
  Files            8        8              
  Lines          345      351       +6     
===========================================
+ Hits           282      288       +6     
  Misses          63       63

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@slager slager changed the title Visc load pdata error Improve an error message in visc_load_pdata() Dec 10, 2024
e-t-h-a-n-w
e-t-h-a-n-w approved these changes Dec 10, 2024
View reviewed changes
Copy link

@e-t-h-a-n-w e-t-h-a-n-w left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

valduran18
valduran18 approved these changes Dec 10, 2024
View reviewed changes
Copy link
Contributor

@valduran18 valduran18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me, thanks Dave!

@slager slager merged commit 4bdaa31 into develop Dec 10, 2024
8 checks passed
@slager slager deleted the visc_load_pdata_error branch December 10, 2024 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@e-t-h-a-n-w e-t-h-a-n-w e-t-h-a-n-w approved these changes

@valduran18 valduran18 valduran18 approved these changes

@kelliemac kelliemac kelliemac approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@slager @kelliemac @valduran18 @e-t-h-a-n-w