Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto-calculate unit test coverage on PRs and view results on Codecov #250

Merged
merged 5 commits into from
Dec 5, 2024

Conversation

slager
Copy link
Contributor

@slager slager commented Nov 6, 2024

  • Worked with FredHutch scicomp to get Codecov permissions & secrets working for VISCtemplates
  • Added GitHub Action to calculate unit test coverage on pushes and PRs
  • Removed oldrel-1 from R CMD check matrix.config, since already testing back to R 4.0.4
  • Added R CMD check and test coverage badges to README
  • Rebuilt README.md from README.Rmd
  • We should start to see the full functionality and benefits once this gets merged into develop / main
    • See here for coverage report example

Copy link

codecov bot commented Nov 6, 2024

Welcome to Codecov 🎉

Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.

Thanks for integrating Codecov - We've got you covered ☂️

@slager slager requested review from kelliemac and mayerbry November 6, 2024 22:37
@slager slager changed the title Codecov token test nit test coverage on PRs Nov 6, 2024
@slager slager changed the title nit test coverage on PRs Auto-calculate unit test coverage on PRs and view results on Codecov Nov 6, 2024
@kelliemac
Copy link
Contributor

@slager looks good to me, thanks for doing this! I just had one comment/request and once you address that I'm happy to approve.

README.md Outdated Show resolved Hide resolved
@slager slager requested a review from kelliemac December 5, 2024 03:46
Copy link
Contributor

@kelliemac kelliemac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks Dave!!

@slager slager merged commit daa8494 into develop Dec 5, 2024
8 checks passed
@slager slager deleted the codecov_token_test branch December 5, 2024 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants