Update PR template to be more comprehensive and usable

[kelliemac]

Description

Updates PR template to be more comprehensive and better organized, so that people are reminded "just-in-time" of the key steps they should be taking before each submitting a PR for review (within an analysis repo).

In particular:

• I exposed the guidance text that was previously in comments so that people would be more likely to pay attention to and modify it.
• I copied the checklists from VISC-documentation directly into the PR template, and added/reorganized/simplified to make the checklists more comprehensive but hopefully not too overwhelming.

Related Issues

Related to #228 and in some sense also #119 and #181

Checklist

• This PR includes unit tests
• This PR establishes a new function or updates parameters in an existing function
  • The roxygen skeleton for this function has been updated using devtools::document
• I have updated NEWS.md to describe the proposed changes

[kelliemac]

@asatofh and @mayerbry I took a stab at updating the analysis repo PR template to be more in line with the actual workflow I use and tasks I know need to be addressed. hoping this will help the PR process become a little smoother for both PR creators and reviewers. any feedback is welcome!!!

[mayerbry]

Thanks Kellie! some super minor comments from me

[kelliemac]

thanks @mayerbry! I incorporated all your suggestions. @asatofh do you want to take a look too, or are you happy for me to merge this PR?

[asatofh]

thanks @mayerbry! I incorporated all your suggestions. @asatofh do you want to take a look too, or are you happy for me to merge this PR?

@kelliemac The main thing I would love to see is more / better instructions to the reviewer about what specifically to review. I know it's already stated, but often forgotten! Something like (highlighted in bold italics for your review):

Here, describe your changes in detail and provide instruction to the reviewer on areas on which you'd like them to focus. Give a short background on the report, outline important questions or details for the reviewer, and add links to any supporting documents (e.g., protocol presentation). It's helpful to add links to the key files with the unique ID for the commit (a.k.a. the "SHA" or "hash").

[kelliemac]

thanks @mayerbry! I incorporated all your suggestions. @asatofh do you want to take a look too, or are you happy for me to merge this PR?

@kelliemac The main thing I would love to see is more / better instructions to the reviewer about what specifically to review. I know it's already stated, but often forgotten! Something like (highlighted in bold italics for your review):

Here, describe your changes in detail and provide instruction to the reviewer on areas on which you'd like them to focus. Give a short background on the report, outline important questions or details for the reviewer, and add links to any supporting documents (e.g., protocol presentation). It's helpful to add links to the key files with the unique ID for the commit (a.k.a. the "SHA" or "hash").

@asatofh I added a section specifically with a checklist for the reviewer. let me know what you think!

[kelliemac]

note to self: need to confirm that this PR template is correctly used in new analysis repos. consider manually copying to pre-made analysis repos when ready as well.