-
-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Guest Upload V2 #178
base: master
Are you sure you want to change the base?
Guest Upload V2 #178
Conversation
Thanks a lot for your hard work! Let me know when it is ready for review or if you need help! |
after reading some more about how it works, i think i'm not going to do e2e encryption support for guest uploads (at least for now). it would require sending the e2e encryption key to anyone with a guest upload token which seems really insecure and a bad idea. right now, if e2e encryption is enabled, guest uploads work just fine but won't be e2e encrypted. i think this is pretty good behaviour, but some warnings that guest uploads aren't encrypted in the docs and setup would be nice i think. |
In theory it would be possible to create a new key for each upload request, but to be honest I am not sure if it would be worth it. Maybe it can be implemented at some point in the future, but I don't see it as a high priority either. |
oki, i've finished everything for the first version
i'd like to submit the code for review now, but i would also appreciate a little help with making the guest upload result page look a little nicer. i'm not good with bootstrap/frontend so i just slapped some stuff together. |
Thanks, I might have some time to review it next week. Would you mind resolving the merge conflicts as well? That would make it a little bit easier |
finished the rebase, take your time with the review! |
Would you mind giving me write access to the branch? I would like to add a function for upgrading the database, otherwise the server crashes if started with an already existing configuration |
Done! |
Thank you. I am not sure if I can review the rest this week, I will probably have more time next week. Also I think it would be a better idea, if the uploaded files are listed in the upload request tab, instead of the main tab, so no confusion exists. In addition it is probably a good idea if multiple files can be uploaded at once and then are grouped together. I will look into it as well however. |
Is this ready for merge? |
Any update on this PR? Would be cool to have this merged! |
Hi, I did not forget about the PR! I am currently implementing a multi user environment, which will bring a lot of changes (and there are already some conflicts). Once that is done, I will try to resolve the conflicts from this PR |
hehe sorry for the long wait :3
i've restarted development on 1.8.4, will rebase onto master when the PR is finished.
i've rewritten the entire feature from scratch and i'm taking more of a minimum viable product approach this time. first version is going to be quite limited, but that should make adding more features later a lot easier.
right now I still have to do the following things: