feature: add generics into binary fuse #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| // the caller should avoid having too many duplicated keys. | ||
| // The function may return an error if the set is empty. | ||
| func PopulateBinaryFuse8(keys []uint64) (*BinaryFuse8, error) { | ||
| func NewBinaryFuse[T Unsigned](keys []uint64) (*BinaryFuse[T], error) { |
There was a problem hiding this comment.
May be hide generic interface and expose only PopulateBinaryFuse8(), PopulateBinaryFuse16(), PopulateBinaryFuse32() publicly to keep API consistent with what we already have.
There was a problem hiding this comment.
That was a trick with configurable types
type MyFuse uint32
...
func main() {
filter := xorfilter.NewBinaryFuse[MyFuse](keys)
second(filter)
}
func second(filter *xorfilter.BinaryFuse[MyFuse]) {
...
}
to change only one line when trying to find best binary fuse for use case. Deprecating PopulateBinaryFuse8.
To be honest I'm tired of switch value := value.(type) usage in established projects. Generics allow to avoid "default" cases as they mostly error, simplify to compiler error.
lemire
reviewed
Sep 10, 2024
|
@tnako This is good and I will merge, but please see my comment which requires a fix. |
|
It has been released. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allow to use uin8, uint16 and uint32 base with binary fuse.
Should be backward compatible with current BinaryFuse8 struct. Only not sure about best go version inside go.mod
What about changing Readme to use new style? Like