Fix package rename #549
Open
Fix package rename #549
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed package rename: - Breaking with nested packages - Breaking the tree view - Failing to remap some classes
2xsaiko
requested changes
Dec 5, 2024
| public void onRenameFromClassTree(ValidationContext vc, String targetName, DefaultMutableTreeNode node) { | ||
| List<EntryChange<ClassEntry>> task = new ArrayList<>(); | ||
| onRenameFromClassTree(targetName, node, task); | ||
| this.controller.applyChanges(vc, task); |
There was a problem hiding this comment.
Suggested change
| this.controller.applyChanges(vc, task); | |
| task.forEach(c -> this.controller.validateChange(vc, task)); | |
| if (!vc.canProceed()) { | |
| return; | |
| } | |
| task.forEach(c -> this.controller.applyChange(vc, task)); |
This is better because now all the changes will be validated and it won't bail out at the first bad one (the iterator in applyChanges you added doesn't validate the rest after one fails) and also won't partially apply a bad change set. This is how this should be used, validate everything first, then actually apply, and they are deliberately separate steps for batch operations like this.
You don't need to change anything about GuiController.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed package rename: