update studio_util neon #383
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a1batross
requested changes
Aug 2, 2023
| @@ -143,8 +143,10 @@ void CrossProduct( const float *v1, const float *v2, float *cross ) | |||
| memcpy(&v1_reg, v1, sizeof(float) * 3); | |||
| memcpy(&v2_reg, v2, sizeof(float) * 3); | |||
|
|
|||
| float32x4_t yzxy_a = vextq_f32(vextq_f32(v1_reg, v1_reg, 3), v1_reg, 2); // [aj, ak, ai, aj] | |||
| float32x4_t yzxy_b = vextq_f32(vextq_f32(v2_reg, v2_reg, 3), v2_reg, 2); // [bj, bk, bi, bj] | |||
| float32x2_t xy_a = vget_low_f32(v1_reg); | |||
There was a problem hiding this comment.
I can't check this code without actually running it. But did you at least tested if it compiles? Because the last time it spewed errors due to invalid data types on Android and Switch.
There was a problem hiding this comment.
It should compile with msvc and clang. Shuffling with qword is faster so I've changed here.
a1batross
requested changes
Aug 7, 2023
| @@ -349,13 +348,28 @@ void CStudioModelRenderer::StudioSlerpBones( vec4_t q1[], float pos1[][3], vec4_ | |||
|
|
|||
| s1 = 1.0f - s; | |||
|
|
|||
| switch (m_pStudioHeader->numbones % 4) | |||
There was a problem hiding this comment.
What if we have only more than 4 bones but not dividable by 4?
For example, 6? With this code, only first 4 bones will be interpolated.
|
Also, the previous set of patches turned out to be glitchy on AArch64 computer running Linux, with GCC 10. Could you check it? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.