Add 7-Zip file type for backups & config option #46
+104
−30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
….zip and .7z Also shade the libraries used for 7-Zip
|
|
MichaelHillcox
requested review from
desht
and removed request for
MaxNeedsSnacks and
MichaelHillcox
|
Tagging our primary dev for this PR but at this moment in time, FTB backups one isn't directly looking features as the mod is effectively EOL |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the option (disabled by default) to create 7-Zip archive files instead of ZIP files for world backups. From my testing, this compression method always creates smaller backup files than ZIP, so with this PR, server hosts can save more space on their hard drives.
Downsides of this PR are that .7z backups take longer to create than .zip, and the library I chose to do the .7z compression must be shaded into FTB-Backups, which I have added in the build.gradle of this PR. I could not test the curseforge publishing task, but building the jar normally works fine in-game.
If necessary, I can update this PR to the 1.18+ version of FTB-Backups whenever that releases.