remove apply_default_restrictions() #329
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ksagiyam
force-pushed
the
ksagiyam/remove_apply_default_restrictions
branch
from
8334f62 to
6bf8021
Compare
ksagiyam
force-pushed
the
ksagiyam/remove_apply_default_restrictions
branch
from
6bf8021 to
61a1e91
Compare
|
@mscroggs Could you please review this PR? |
mscroggs
approved these changes
Dec 13, 2024
dham
approved these changes
Dec 18, 2024
|
Thanks you. |
Thank you for fixing this. I'm happy to see some almost-duplicate code paths disappear! |
pbrubeck
pushed a commit
to firedrakeproject/ufl
that referenced
this pull request
Dec 18, 2024
Fix action space check ruff unsafe ruff symmetric space check fix import conflict Fix action space check (FEniCS#331) * Fix action space check * ruff * unsafe ruff * symmetric space check * fix import conflict remove apply_default_restrictions() (FEniCS#329) * ruff==0.8.0 * remove apply_default_restrictions() --------- Co-authored-by: Matthew Scroggs <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge
apply_default_restrictions()intoapply_restrictions().