Handle numpy metadata (quadrature arrays) without throwing a warning #293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dham
reviewed
Jun 11, 2024
| @@ -84,6 +86,8 @@ def canonicalize_metadata(metadata): | |||
| value = str(value) | |||
| elif hasattr(value, "ufl_signature"): | |||
| value = value.ufl_signature | |||
| elif isinstance(value, np.ndarray): | |||
| value = np.array2string(value, separator=" ") | |||
There was a problem hiding this comment.
Is this safe? That array can get quite big.
There was a problem hiding this comment.
This is what happens for a numpy array as input to metadata atm irregardless (just throws a user warning).
There was a problem hiding this comment.
Sure, I'm just nervous about silencing a warning that might have an actual point.
There was a problem hiding this comment.
If we want to avoid people sending in large arrays of custom quadrature points/weights we should find a better way to let people patch in custom quadrature rules.
Currently they have to be implemented in FINAT/FIAT/basix?
There was a problem hiding this comment.
Let's discuss this in person tomorrow. I have ideas.
|
Issue opened in #294 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handle string conversion of numpy arrays without throwing a UserWarning.