Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor cells #168

Merged
merged 21 commits into from
Jun 27, 2023
Merged

Refactor cells #168

Show file tree
Hide file tree
Changes from 9 commits
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
df7e7b7
refactor cell to be an abstract base class
mscroggs Jun 7, 2023
7cfc225
quadrilateral has simplex facets
mscroggs Jun 7, 2023
d298fb9
rename classes (for Firedrake compatibility)
mscroggs Jun 7, 2023
25496ac
renamings I missed
mscroggs Jun 7, 2023
7a8d8e4
ffc branch
mscroggs Jun 7, 2023
7b1b3e8
Add reconstruct to base class
mscroggs Jun 7, 2023
7d3f177
more renaming
mscroggs Jun 7, 2023
f3cee17
_s
mscroggs Jun 7, 2023
4d00df8
remove todo
mscroggs Jun 7, 2023
abeeb35
typing_extensions
mscroggs Jun 8, 2023
7d11209
requirement for Python < 3.10?
mscroggs Jun 8, 2023
9e36088
3.11 not 3.10 (!)
mscroggs Jun 8, 2023
621fab4
docstring fixes, remove volume
mscroggs Jun 8, 2023
497ef78
compute once, not every time
mscroggs Jun 8, 2023
ffef94f
=
mscroggs Jun 8, 2023
cb03b5e
do it properly
mscroggs Jun 8, 2023
fb1c123
reorder
mscroggs Jun 8, 2023
a13f6c4
prevent recursion (!)
mscroggs Jun 8, 2023
41ba75f
make sub_entity_types a tuple
mscroggs Jun 19, 2023
3d01873
use tuples, simplify
mscroggs Jun 19, 2023
ad0be1d
use weakref
mscroggs Jun 19, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/fenicsx-tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ jobs:
with:
path: ./ffcx
repository: FEniCS/ffcx
ref: main
ref: mscroggs/ufl-cell
- name: Install FFCx
run: |
cd ffcx
Expand Down Expand Up @@ -78,7 +78,7 @@ jobs:
- name: Install Basix and FFCx
run: |
python3 -m pip install git+https://github.com/FEniCS/basix.git
python3 -m pip install git+https://github.com/FEniCS/ffcx.git
python3 -m pip install git+https://github.com/FEniCS/ffcx.git@mscroggs/ufl-cell

- name: Clone DOLFINx
uses: actions/checkout@v3
Expand Down
Loading