Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow colors to continue across lines #11

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

haltman-at
Copy link

@haltman-at haltman-at commented Jul 12, 2019

(Apologies about this PR accidentally including my previous one as well. If it turns out you like this one but not the previous one, well, we can figure out how to rebase things to separate it out later. Sorry, I didn't think I was going to be making multilpe PRs!) (Fixed this now.)

This PR fixes a bug whereby colors won't continue across lines. This is because chromafi currently colors the code line-by-line rather than all at once. So, I've modified the code to simply colorize all at once. Now, colors can continue across lines.

Thanks!

@coveralls
Copy link

coveralls commented Jul 12, 2019

Pull Request Test Coverage Report for Build 46

  • 3 of 3 (100.0%) changed or added relevant lines in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.8%) to 98.872%

Files with Coverage Reduction New Missed Lines %
index.js 1 98.87%
Totals Coverage Status
Change from base Build 37: -0.8%
Covered Lines: 180
Relevant Lines: 181

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants