Remove strip to avoid issue when the final header is blank - with tests! #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Following removal of event body strip(), leading blank line in disconnect_event sample caused ESLEvent.parse_data to attempt a multi-line continuation before having a valid Key: Value pair to continue from. Fix removes leading blank line to match other event samples in tests.
and blank value in arbitrary position.
talmakion
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refer issue #67, fixing events with a blank final header and whitespace stripping in ESLEvent.parse_data().
This is an updated pull request from earlier, rebased on current master with fixed and added tests.