Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use object shorthand for properties #170

Closed
wants to merge 1 commit into from
Closed

Use object shorthand for properties #170

wants to merge 1 commit into from

Conversation

LinusU
Copy link

@LinusU LinusU commented Apr 26, 2020

This rule is on its way into the latest Standard ☺️

ref: standard/eslint-config-standard#166

@LinusU LinusU mentioned this pull request Apr 26, 2020
Merged
58 tasks
EvanHahn
EvanHahn requested changes Apr 26, 2020
View reviewed changes
Copy link
Owner

@EvanHahn EvanHahn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this but I want to make sure this library works in old browsers without transpilation, so I don't think I can accept this.

@LinusU
Copy link
Author

LinusU commented Apr 26, 2020

Absolutely, sorry for missing that this was meant to be used untranspiled for browsers 👍

I'll keep this in mind if we maybe want to add a way to indicate support for older environments, and in that case not enforce the rule ☺️ closing for now

@LinusU LinusU closed this Apr 26, 2020
@EvanHahn
Copy link
Owner

EvanHahn commented Apr 26, 2020 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EvanHahn EvanHahn EvanHahn requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@LinusU @EvanHahn