Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle tcp-ip-forward global request responses. #148

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jimmyvanhest
Copy link

When a tcp-ip-forward global request is sent a REQUEST_SUCCESS or a REQUEST_FAILURE response is expected and should be handled. this is also an opportunity to parse and return the port number returned by the server.

@Eugeny
Copy link
Owner

Eugeny commented Mar 7, 2023

Welcome and thank you for your contribution!

Unfortunately read_u32 is failing when there's no port info in the request (e.g. in the success response of the cancel-tcpip-forward request)

The session should either remember the type of the last global request and act accordingly or in the worst case, just ignore a missing port field.

@Eugeny Eugeny added the help wanted Extra attention is needed label Apr 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants