Quoted column identifiers

[dhwdeca]

Closes #141

[rogersnick]

I'm new here, and was browsing the open PRs, but this seems pretty snowflake specific -- does it make sense to use the quote_identifier macro here?

It sounds like capitalized identifiers are valid, and that would dispatch to snowflake__quote_identifier which surrounds the column name in double quotes and capitalizes it:

return('"' ~ identifier | upper ~ '"')

This would let users of the library override the behaviour in their projects if needed.

[dhwdeca]

Thanks for the comment, Nick. You make a good point.
Coincidentally I was having the exact same conversation at a hackathon last night.

I will be updating this to a more generic/technology agnostic implementation.

EDIT: Updated it, using the quote_identifier, but I extended it with an optional preserve_case argument, as the capitalization is the thing I specifically didn't want in Snowflake.

[Tideorz]

@cdiniz , could this be merged into main? We also have the same problem for column needs quote

[dhwdeca]

Hi All,
With some of the latest commits, the way I implemented this no longer worked.
I've taken a different approach and opened a new merge request: #194
Feel free to return to the discussion there and push to give this some attention so we can get this included in the main release.