-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automatically fetch and register PjRT Metal plugin #99
base: main
Are you sure you want to change the base?
Conversation
Benchmark Results
Benchmark PlotsA plot of the benchmark results have been uploaded as an artifact to the workflow run for this PR. |
I think just macos CI should do it, no? |
@@ -183,6 +183,32 @@ extern "C" PjRtClient* MakeTPUClient(const char* tpu_path , const char** error) | |||
return GetCApiClient("TPU"); | |||
} | |||
|
|||
const char* const kEnvMetalLibraryPath = "METAL_LIBRARY_PATH"; | |||
|
|||
extern "C" PjRtClient* MakeMetalClient(const char* libpath, const char** error) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we avoid making a separate api change atm since the oher loadpjrt plugins have an api presently?
Just for the sake of setting it up without a jll bump
We might want to use the buildkite ones here. The macos-large GH runners have GPUs but those are paid. The free ones don't have GPU. Buildkite script for that https://github.com/LuxDL/MLDataDevices.jl/blob/b7e05516c0c0ec554259d90b5d620b6d0bf12154/.buildkite/testing.yml#L110-L134. |
Fair nuff/sgtm
…On Wed, Sep 4, 2024 at 7:41 PM Avik Pal ***@***.***> wrote:
I think just macos CI should do it, no?
We might want to use the buildkite ones here. The macos-large GH runners
have GPUs but those are paid. The free ones don't have GPU.
Buildkite script for that
https://github.com/LuxDL/MLDataDevices.jl/blob/b7e05516c0c0ec554259d90b5d620b6d0bf12154/.buildkite/testing.yml#L110-L134
.
—
Reply to this email directly, view it on GitHub
<#99 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAJTUXFRVUORGMVZHQ2KIQTZU6SEJAVCNFSM6AAAAABNVBCWW2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMZQGM4DGMBXGY>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
||
try | ||
metal = MetalClient(metaldir * "/pjrt_plugin_metal_14.dylib") | ||
backends["metal"] = metal |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We might as well just label this as gpu
PjRT_Metal_jll
package@wsmoses is there a Metal infra available for testing?