Add aws irsa auth #1021
Add aws irsa auth #1021
Conversation
barman/cloud_providers/aws_s3.py
Outdated
| @@ -102,6 +103,7 @@ def __init__( | |||
| self, | |||
| url, | |||
| encryption=None, | |||
| aws_irsa=False, | |||
There was a problem hiding this comment.
please relocate this new argument at the end of the argument list to preserve the original signature @smcaine
|
@smcaine thanks for your contribution. I've put a suggestion in the code during my review of the pr. The code seems correct but your patch has broken the Unit Tests for Barman, because of this we cannot merge the PR as it is. Could you fix the failing tests? FYI we are working on some contribution guidelines for PRs and what I'm asking will be part of this new documentation section. Thanks. |
smcaine
force-pushed
the
add-aws-irsa-auth
branch
from
181e3bb to
f6c55a5
Compare
|
Hi Stuart, as mentioned before, your PR is failing for tox tests. Can you check these and push a fix that makes them pass? https://github.com/EnterpriseDB/barman/actions/runs/11720727101/job/32805402247?pr=1021 There are also flack errors that need addressing: https://github.com/EnterpriseDB/barman/actions/runs/11720727101/job/32805400982?pr=1021 |
yes, apologies, i have not been able to pick this up, will start running through these and add tests for the work done in the PR |
smcaine
force-pushed
the
add-aws-irsa-auth
branch
from
d144f87 to
36737b1
Compare
|
Can these tests be re-run? Hopefully I've covered everything. Ive just revised PR so its clear this is just for EKS and IAM role Service accounts |
smcaine
force-pushed
the
add-aws-irsa-auth
branch
from
2f7347f to
7a34ee7
Compare
Adding this flag to use the service account iam role, for when using eks: https://docs.aws.amazon.com/eks/latest/userguide/iam-roles-for-service-accounts-minimum-sdk.html
Using aws access keys is bad practice and typically prohibited in most production environments.
This relates to issue i raised #949