Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typos #613

Merged
merged 1 commit into from
Dec 22, 2024
+16 −7
Merged

Fix typos #613

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion object/src/file.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,7 @@ impl<D, T> OpenFileOptions<D, T> {
}

/// Set the transfer syntax index to use when reading the file.
pub fn tranfer_syntax_index<Tr>(self, ts_index: Tr) -> OpenFileOptions<D, Tr>
pub fn transfer_syntax_index<Tr>(self, ts_index: Tr) -> OpenFileOptions<D, Tr>
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changing the name of this public function would be a breaking change now. We can 1) postpone this change until the time we aim for 0.9, or 2) re-add tranfer_syntax_index as a deprecated function which calls transfer_syntax_index underneath.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will re-add as deprecated. I should have thought of that!

where
Tr: TransferSyntaxIndex,
{
Expand All @@ -116,6 +116,15 @@ impl<D, T> OpenFileOptions<D, T> {
}
}

/// Set the transfer syntax index to use when reading the file.
#[deprecated(since="0.8.1", note="please use `transfer_syntax_index` instead")]
pub fn tranfer_syntax_index<Tr>(self, ts_index: Tr) -> OpenFileOptions<D, Tr>
where
Tr: TransferSyntaxIndex,
{
self.transfer_syntax_index(ts_index)
}

/// Set the data element dictionary to use when reading the file.
pub fn dictionary<Di>(self, dict: Di) -> OpenFileOptions<Di, T>
where
Expand Down
2 changes: 1 addition & 1 deletion object/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -351,7 +351,7 @@ impl AccessError {
#[non_exhaustive]
#[snafu(visibility(pub(crate)))]
pub enum AtAccessError {
/// Missing itermediate sequence for {selector} at step {step_index}
/// Missing intermediate sequence for {selector} at step {step_index}
MissingSequence {
selector: AttributeSelector,
step_index: u32,
Expand Down
2 changes: 1 addition & 1 deletion object/src/ops.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ use crate::FileDicomObject;
#[non_exhaustive]
#[snafu(visibility(pub(crate)))]
pub enum ApplyError {
/// Missing itermediate sequence for {selector} at step {step_index}
/// Missing intermediate sequence for {selector} at step {step_index}
MissingSequence {
selector: AttributeSelector,
step_index: u32,
Expand Down
4 changes: 2 additions & 2 deletions storescp/src/store_async.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ pub async fn run_store_async(
} else if data_value.value_type == PDataValueType::Command
&& data_value.is_last
{
// commands are always in implict VR LE
// commands are always in implicit VR LE
let ts =
dicom_transfer_syntax_registry::entries::IMPLICIT_VR_LITTLE_ENDIAN
.erased();
Expand Down Expand Up @@ -193,7 +193,7 @@ pub async fn run_store_async(
info!("Stored {}", file_path.display());

// send C-STORE-RSP object
// commands are always in implict VR LE
// commands are always in implicit VR LE
let ts =
dicom_transfer_syntax_registry::entries::IMPLICIT_VR_LITTLE_ENDIAN
.erased();
Expand Down
4 changes: 2 additions & 2 deletions storescp/src/store_sync.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@ pub fn run_store_sync(scu_stream: TcpStream, args: &App) -> Result<(), Whatever>
} else if data_value.value_type == PDataValueType::Command
&& data_value.is_last
{
// commands are always in implict VR LE
// commands are always in implicit VR LE
let ts =
dicom_transfer_syntax_registry::entries::IMPLICIT_VR_LITTLE_ENDIAN
.erased();
Expand Down Expand Up @@ -191,7 +191,7 @@ pub fn run_store_sync(scu_stream: TcpStream, args: &App) -> Result<(), Whatever>
info!("Stored {}", file_path.display());

// send C-STORE-RSP object
// commands are always in implict VR LE
// commands are always in implicit VR LE
let ts =
dicom_transfer_syntax_registry::entries::IMPLICIT_VR_LITTLE_ENDIAN
.erased();
Expand Down
Loading