Add transcoder API #408
Merged
Add transcoder API #408
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enet4
added
A-lib
Enet4
force-pushed
the
imp/pixeldata/transcode
branch
from
edd3a42 to
da335dd
Compare
Enet4
force-pushed
the
imp/pixeldata/transcode
branch
from
9c49a67 to
63cf247
Compare
- `Transcode` trait can convert objects inline between transfer syntaxes - expose `Transcode` and error/result types
- add root module documentation - add `Transcode::transcode_with_options` and add default impl for `Transcode::transcode` - fix implementation according to v0.6 - add more docs to `Transcode` - add more module-level tests
- hide Ok at the end
- fix frame retrieval from native pixel data - improve handling of high bit depth dat by narrowing it down to 8 bits if necessary
- CLI tool for transcoding files, gated behind feature "cli" - include "cli" feature in CI
- new Cargo feature "transcode"
- feature-gate dicom-pixeldata on "transcode"
- if enabled, try to decode the file to explicit VR LE
when the SCP does not accept the original TS
- add option never_transcode,
to support retaining the previous behavior
Enet4
force-pushed
the
imp/pixeldata/transcode
branch
from
63cf247 to
88d3edf
Compare
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is revision 1 of the new transcoding API and CLI, a convenient trait for converting an object to another transfer syntax.
Summary
dicom_pixeldata::transcodemodule, containsTranscodetrait and transcoder error type[encoding] Fix default impl of(already done in Fix padding skipping in multiframe JPEG decoding #414)PixelDataWriter::encodeso that it doesn't throw an error on missing Number of Framesdicom-transcode, a CLI tool for transcoding DICOM files.