Minor tweaks for previous commit

Elao · May 31, 2019 · ffea0fd · ffea0fd
1 parent ec2f904
commit ffea0fd
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 5 deletions.
diff --git a/DependencyInjection/ElaoErrorNotifierExtension.php b/DependencyInjection/ElaoErrorNotifierExtension.php
@@ -16,7 +16,6 @@
 use Symfony\Component\DependencyInjection\Reference;
 use Symfony\Component\HttpKernel\DependencyInjection\Extension;
 
-
 /**
  * ElaoErrorNotifier Extension
  */
@@ -46,11 +45,13 @@ public function load(array $configs, ContainerBuilder $container)
                 $definition->replaceArgument(0, new Reference($config['mailer']));
             }
 
-            if (true === class_exists('Symfony\Component\Console\Event\ConsoleErrorEvent')) {
-                $definition->addTag('kernel.event_listener', ['event' => 'console.error', 'method' => 'onConsoleError', 'priority' => 0]);
+            if (class_exists('Symfony\Component\Console\Event\ConsoleErrorEvent')) {
+                $listenerTag = array('event' => 'console.error', 'method' => 'onConsoleError', 'priority' => 0);
             } else {
-                $definition->addTag('kernel.event_listener', ['event' => 'console.exception', 'method' => 'onConsoleException', 'priority' => 0]);
+                $listenerTag = array('event' => 'console.exception', 'method' => 'onConsoleException', 'priority' => 0);
             }
+
+            $definition->addTag('kernel.event_listener', $listenerTag);
         }
     }
 }
diff --git a/Listener/Notifier.php b/Listener/Notifier.php
@@ -138,7 +138,7 @@ public function onKernelException(GetResponseForExceptionEvent $event)
             }
         }
     }
-    
+
     /**
      * Handle the console exceptions (Symfony 2.3-3.4)
      *

diff --git a/Resources/config/services.xml b/Resources/config/services.xml
@@ -13,6 +13,7 @@
             <tag name="kernel.event_listener" event="kernel.exception" method="onKernelException" priority="0"/>
             <tag name="kernel.event_listener" event="kernel.request" method="onKernelRequest" priority="0"/>
             <tag name="kernel.event_listener" event="console.command" method="onConsoleCommand" priority="0"/>
+            <!-- console.exception or console.error (from bundle extension) depending on symfony/console version -->
             <argument type="service" id="mailer" />
             <argument type="service" id="twig" />
             <argument>%kernel.cache_dir%</argument>
-Original file line number
+Diff line change
@@ Expand Up @@
                 }
             }
         }
         /**
          * Handle the console exceptions (Symfony 2.3-3.4)
          *
@@ Expand Down @@