add wechat support #278
add wechat support #278
Conversation
|
|
|
+1 to this |
|
👍 |
|
why this pull request is rejected to merge ? I have created a updated version here: https://github.com/pluswave/SocialSharing-PhoneGap-Plugin for latest master and fix some issues and add title support, should I create a new pull request ? |
|
@pluswave I don't think this PR is rejected, the maintainers just haven't gotten around to reviewing it. 👍 too btw |
|
My main issue with this is that this plugin doesn't embed any native SDK's. Wechat would be the first and the plugin jumps from 0,9KB to 7,3MB. If I'd add all native SDK's you can imagine what would happen. Perhaps a sep wechat plugin would make more sense. Curious to learn what you guys think, although you're a bit biased I guess ;) But I'll give it some thought since there's high demand. Can you submit a PR as this one can no longer be merged (or an update to this one is fine as well of course). |
|
We really want to this plugin can support sharing to wechat, even with plugin or whatever method. At least an image and url can be shared. Thanks a lot for the hard working for this plugin. |
|
Great! Is it merged to the main branch already? |
add wechat support