Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the environment use the most common pre-commit package to avoid adding two and fix syntax warning #45

Merged
merged 3 commits into from
Dec 6, 2023

Conversation

lincrosenbach
Copy link
Contributor

@lincrosenbach lincrosenbach commented Dec 6, 2023

SyntaxWarning: "is" with a literal. Did you mean "=="?
if serializer_strategy is "NestedModelFields"

Copy link

codecov bot commented Dec 6, 2023

Codecov Report

Merging #45 (64b9dae) into master (568b733) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files
@@           Coverage Diff           @@
##           master      #45   +/-   ##
=======================================
  Coverage   88.82%   88.82%           
=======================================
  Files          22       22           
  Lines        1065     1065           
=======================================
  Hits          946      946           
  Misses        119      119           

src/serialchemy/_tests/test_nested_fields.py Outdated Show resolved Hide resolved
Co-authored-by: Lucas Oliveira <[email protected]>
Copy link

sonarqubecloud bot commented Dec 6, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@lincrosenbach lincrosenbach merged commit 87f002b into master Dec 6, 2023
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants