Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PIO sync for potentially better robustness for gnu/cray-mpich and a few cleanups #453

Merged
merged 9 commits into from
Mar 7, 2024

Conversation

nmizukami
Copy link
Collaborator

@nmizukami nmizukami commented Jan 24, 2024

We found that cesm-coupling.n02_v2.1.2 produces the history output problem for the gnu (12.2.0) / mpich (8.1.27) compiled executable. pio_sync was added after writing the history file and this reduces the occurrence of this error (but not completely eliminating this problem). Note: Jim mentioned when netcdf is closed, pio_sync happens so no explict call for pio_sync is needed.

Note: This problem does occur only for the executable compiled with gnu/mpich. gnu/openmpi (5.0.0) and intel/mpich work fine.

Further debugging for gnu/mpich is needed, but at this point, unclear about root cause of the problem. This might be related to #359

Switching netcdf type from pnetcdf to netcdf clear this problem (for gnu (12.2.0) / mpich (8.1.27)). Therefore, expose the pio_netcdf_type to user control file. so user can specify netcdf type without re-compiling the code (pio_netcdf_type was hard-coded as pnetcdf.)

Fixed library (PIO) Makefile bug that cause the compiling error when you use only netCDF and gcc.

Other changes include removing unused variables or routines

@nmizukami nmizukami added cleanup clean up the codes (remove unnecessary lines, indentation, styles) bugfix labels Jan 24, 2024
@nmizukami nmizukami requested a review from ekluzek January 24, 2024 12:24
@nmizukami
Copy link
Collaborator Author

nmizukami commented Mar 7, 2024

At least using standard netcdf for PIO works for gcc with mpich (not parallel-netcdf), and several compiling issues for recent compilers (both intel and gcc)

  • issue on gcc and intel with mpich using standard parallel netcdf.
  • issue on cmake flag
  • issue on recent gcc compile (Rank mismatch between actual arguments)

So merge this now.

@nmizukami nmizukami merged commit 74e4344 into ESCOMP:cesm-coupling Mar 7, 2024
@nmizukami nmizukami deleted the cesm-coupling_patch branch March 7, 2024 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix cleanup clean up the codes (remove unnecessary lines, indentation, styles)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant