feat: Add rawToken Field to Visa with temp Security Measures
#315
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR introduces the rawToken field to the Visa POJO to facilitate delegation of tasks by APIs above the Clearing House to external services (such as SDA and DOA). To mitigate security risk associated with this sensitive field: The rawToken field has been marked as transient to prevent unintended serialization. @ToString.Exclude is used to ensure it is not exposed in logs or debug outputs. Notes: The addition of rawToken is a temporary solution. We need to explore alternative designs to eliminate this field from the POJO entirely while maintaining functionality for task delegation. This PR provides an immediate workaround to secure sensitive data until a long-term solution is implemented.
Parisa68
approved these changes
Nov 26, 2024
kjellp
approved these changes
Nov 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces the
rawTokenfield to the Visa POJO to facilitate delegation of tasks by APIs above the Clearing House to external services (such as SDA and DOA). To mitigate security risk associated with this sensitive field:The rawToken field has been marked as transient to prevent unintended serialization.
@ToString.Excludeis used to ensure it is not exposed in logs or debug outputs.Notes:
The addition of
rawTokenis a temporary solution. We need to explore alternative designs to eliminate this field from the POJO entirely while maintaining functionality for task delegation. This PR provides an immediate workaround to secure sensitive data until a long-term solution is implemented.