New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add the MQ-interceptor service #30

Merged

kjetilkl merged 1 commit into main from add_mq-interceptor

Jan 26, 2024

Contributor

kjetilkl commented Jan 11, 2024

No description provided.


          Add the MQ-interceptor service

d65168b

kjetilkl added the MQ-interceptor label

kjetilkl assigned joshbaskaran

Contributor

joshbaskaran commented Jan 15, 2024 •

edited

Loading

A couple of things before we merge this in:

The CodeQL workflow file should be updated to also cover Go projects.
Add the relevant dependabot config to catch dependency updates for this project

Some additional things I think we should consider, especially given that this is a tiny project (under 200 lines):

We should probably add tests.
Also, I'm not a Go developer and might have spent too much time in Java land so you may ignore this, but having everything right under the project folder feels rather odd. If there are commonly accepted conventions, we should probably adapt those it.

What do you guys think? @ELIXIR-NO/fega-norway

joshbaskaran added the import label

kjetilkl merged commit e0340f4 into main

4 checks passed

kjetilkl deleted the add_mq-interceptor branch

January 26, 2024 10:34

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

import MQ-interceptor