Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade from Java 17 to Java 21 #29

Merged
merged 3 commits into from
Jan 9, 2024
Merged

Upgrade from Java 17 to Java 21 #29

merged 3 commits into from
Jan 9, 2024

Conversation

Parisa68
Copy link
Contributor

@Parisa68 Parisa68 commented Jan 8, 2024 •
edited by joshbaskaran
Loading

  • gradle 8.4 to 8.5
  • java 17 to 21

@Parisa68 Parisa68 added java Pull requests that update Java code configuration Pull requests that modifies config files workflows Pull requests that update the GitHub workflows labels Jan 8, 2024
@joshbaskaran joshbaskaran changed the title upgrade Upgrade from Java 17 to Java 21 Jan 9, 2024
joshbaskaran
joshbaskaran requested changes Jan 9, 2024
View reviewed changes
Copy link
Contributor

@joshbaskaran joshbaskaran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you amend the commit message to Java 21? Otherwise, looks good :)

@Parisa68 Parisa68 merged commit b7d3015 into main Jan 9, 2024
4 checks passed
@Parisa68 Parisa68 deleted the upgrade-java-gradle-version branch January 9, 2024 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshbaskaran joshbaskaran joshbaskaran requested changes

Assignees
No one assigned
Labels
configuration Pull requests that modifies config files java Pull requests that update Java code workflows Pull requests that update the GitHub workflows
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Parisa68 @joshbaskaran