clean ${tmpdir} after iterations in install_cuda_and_libraries.sh
#814
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Instance
|
|
Instance
|
|
Instance
|
TopRichard
added
2023.06-software.eessi.io
|
bot: build repo:eessi.io-2023.06-software arch:x86_64/generic |
Updates by the bot instance
|
Updates by the bot instance
|
Updates by the bot instance
|
|
New job on instance
|
trz42
requested changes
Nov 18, 2024
There was a problem hiding this comment.
Removing the full ${tmpdir} inside the loop likely lets the script fail if one processes multiple easystack files. However, the tmpdir directory is only needed for each loop iteration, so we don't need to wait with the clean up until the loop has processed all easystack files.
added 2 commits
November 18, 2024 12:53
…ftware-layer into eessi-2023.06-fix-clean-up-dir-install_cuda_and_libraries.sh
TopRichard
force-pushed
the
eessi-2023.06-fix-clean-up-dir-install_cuda_and_libraries.sh
branch
from
1f6487e to
66c36c8
Compare
|
bot: build repo:eessi.io-2023.06-software arch:x86_64/generic |
Updates by the bot instance
|
Updates by the bot instance
|
Updates by the bot instance
|
|
New job on instance
|
trz42
added
the
bot:deploy
|
Label |
|
PR merged! Moved |
|
PR merged! Moved |
|
PR merged! Moved |
ocaisa
reviewed
Nov 19, 2024
| # clean up tmpdir | ||
| rm -rf "${tmpdir}" | ||
| # clean up tmpdir content | ||
| rm -rf "${tmpdir}"/* |
There was a problem hiding this comment.
Shouldn't we then remove ${tmpdir} after the loop?
There was a problem hiding this comment.
Yes, but that approach only removes the contents of $tmpdir, never $tmpdir itself. This can be done outside the loop, see #816
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
${tmpdir}can be cleaned after all iterations are done when having multipleeasystacks/eessi-*CUDA*.ymlfiles