Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Take accelerator builds into account in CI that checks for missing installations #753

Merged

Conversation

bedroge
Copy link
Collaborator

@bedroge bedroge commented Sep 27, 2024

It doesn't really seem possible to add complex combinations into the workflow matrix, and maybe we don't want that anyway (for instance because the accelerator builds also need the CPU stack). So, I've now defined a CPU->accelerators mapping and use that to:

  • first run the "check missing" script for the CPU-only stack
  • look up the accelerator targets for this particular CPU target
  • loop over all accelerator targets and do the following for each of them:
    • prepend the module dir of this accelerator target to $MODULEPATH
    • run the "check missing" script for every accelerator easystack file
    • remove the module dir from the $MODULEPATH again

Copy link

eessi-bot bot commented Sep 27, 2024

Instance eessi-bot-mc-aws is configured to build for:

  • architectures: x86_64/generic, x86_64/intel/haswell, x86_64/intel/skylake_avx512, x86_64/amd/zen2, x86_64/amd/zen3, aarch64/generic, aarch64/neoverse_n1, aarch64/neoverse_v1
  • repositories: eessi.io-2023.06-compat, eessi-hpc.org-2023.06-software, eessi-hpc.org-2023.06-compat, eessi.io-2023.06-software

Instance boegel-bot-deucalion is configured to build for:

  • architectures: aarch64/a64fx
  • repositories: eessi.io-2023.06-software

Copy link

eessi-bot bot commented Sep 27, 2024

Instance eessi-bot-mc-azure is configured to build for:

  • architectures: x86_64/amd/zen4
  • repositories: eessi-hpc.org-2023.06-software, eessi-hpc.org-2023.06-compat, eessi.io-2023.06-software, eessi.io-2023.06-compat

.github/workflows/test-software.eessi.io.yml Outdated Show resolved Hide resolved
.github/workflows/test-software.eessi.io.yml Outdated Show resolved Hide resolved
@bedroge
Copy link
Collaborator Author

bedroge commented Sep 27, 2024

https://github.com/bedroge/software-layer/actions/runs/11067076764/job/30749648105
This is an older run where I used a wrong modulepath, it shows that it indeed fails when the accelerator builds cannot be found (hadn't synced my branch yet, so it only complains about LAMMPS).

Copy link
Contributor

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boegel boegel added 2023.06-software.eessi.io 2023.06 version of software.eessi.io accel:nvidia tests Related to software testing labels Sep 27, 2024
@boegel boegel merged commit 095ab30 into EESSI:2023.06-software.eessi.io Sep 27, 2024
35 checks passed
Copy link

eessi-bot bot commented Sep 27, 2024

PR merged! Moved [] to /project/def-users/SHARED/trash_bin/EESSI/software-layer/2024.09.27

PR merged! Moved [] to $HOME/trash_bin/EESSI/software-layer/2024.09.27

Copy link

eessi-bot bot commented Sep 27, 2024

PR merged! Moved [] to /project/def-users/SHARED/trash_bin/EESSI/software-layer/2024.09.27

@bedroge bedroge deleted the check_missing_for_accels branch September 27, 2024 09:43
@boegel
Copy link
Contributor

boegel commented Sep 27, 2024

@trz42 We should make the bot shut up when it didn't actually move anything?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2023.06-software.eessi.io 2023.06 version of software.eessi.io accel:nvidia tests Related to software testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants